Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use gcloud.cmd to invoke gcloud on Windows #113

Merged
merged 1 commit into from
May 29, 2024

Conversation

andreban
Copy link
Contributor

On Windows, the name of the gcloud command is gcloud.cmd, while on MacOS and Linux the name is just gcloud.

While on the Windows Command prompt invoking gcloud works, this is not the case when a process is spawned with Rust's Command, causing the application to fail to execute the command.

As a solution, we introduce an OS specific variable reflecting the actual command name for each OS.

Closes #111

On Windows, the name of the `gcloud` command is `gcloud.cmd`,
while on MacOS and Linux the name is just `gcloud`.

While on the Windows Command prompt invoking `gcloud` works, this
is not the case when a process is spawned with Rust's `Command`,
causing the application to fail to execute the command.

As a solution, we introduce an OS specific variable reflecting the
actual command name for each OS.
Copy link
Owner

@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@djc djc merged commit 7fe074d into djc:main May 29, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to find the gcloud command on Windows
2 participants