Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The image and file fields where nolonger working. #337

Merged
merged 2 commits into from
Mar 18, 2024

Conversation

specialunderwear
Copy link
Member

This PR restores that functionality.

This PR restores that functionality.
@@ -63,6 +69,7 @@ class AttributeConverter(AttributeFieldBase):
def __init__(self, context):
self.context = context
self.errors = []
self.parent = None
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

waar is dit voor

@viggo-devries viggo-devries merged commit f3f041e into master Mar 18, 2024
2 checks passed
@viggo-devries viggo-devries deleted the restore-attribute-file-functionality branch March 18, 2024 10:49
samar-hassan pushed a commit that referenced this pull request Sep 19, 2024
* Optimize attribute values (#321)

* Implemented faster attributes save

* renamed for clarity

* Renamed warning

* Enable shortcut when saving child products. (#322)

* Make sure to only return attributevalues that are on the actual product to avoid transferring (#331)

attributesvalues from parent to child.

* Improve multi db support (#335)

Use the same database as the passed-in manager

* The image and file fields where nolonger working. (#337)

* The image and file fields where nolonger working.

This PR restores that functionality.

* nergens voor

* fixes tests

* black

* Fixes cyclic import error

* Fixes handling of null product image attributes

When an image product attribute is `null`, the product API would throw the
following exception:

```
ValueError: The 'value_image' attribute has no file associated with it.

  […]

  File "rest_framework/serializers.py", line 522, in to_representation
    ret[field.field_name] = field.to_representation(attribute)
  File "rest_framework/serializers.py", line 686, in to_representation
    return [
  File "rest_framework/serializers.py", line 687, in <listcomp>
    self.child.to_representation(item) for item in iterable
  File "rest_framework/serializers.py", line 522, in to_representation
    ret[field.field_name] = field.to_representation(attribute)
  File "oscarapi/serializers/fields.py", line 227, in to_representation
    return value.value.url
  File "django/db/models/fields/files.py", line 66, in url
    self._require_file()
  File "django/db/models/fields/files.py", line 41, in _require_file
    raise ValueError(
```

This patch fixes this by checking if the image field has a value before trying
to generate a URL.

* Add category bulk admin api

* Add tests to prove how it works

* wops

* Added Jenkinsfile

* hehe

* set to next release version

* Setup local CI (#348)

* Improve category upsert and add test (#352)

* Doe some updating and add test

* refrhes_from_db only path

* Add transaction that rollsback on error

* update versions

---------

Co-authored-by: Craig Weber <crgwbr@gmail.com>
Co-authored-by: Viggo de Vries <viggo@highbiza.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants