-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Creates an initial newsletter sign-up form #33
Open
benjaoming
wants to merge
2
commits into
django-denmark:new
Choose a base branch
from
benjaoming:consent-form
base: new
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Empty file.
Empty file.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
{% extends "base.html" %} | ||
|
||
|
||
{% comment %} | ||
This part of the demo shows how you can overwrite consent/base.html in order to | ||
have your own main template apply to django-consent's built-in templates. | ||
|
||
Simply place the consent_content block in the appropriate location. | ||
{% endcomment %} | ||
|
||
{% block content %} | ||
{% block consent_content %} | ||
|
||
{% endblock %} | ||
{% endblock %} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
{% extends "base.html" %} | ||
|
||
{% block content %} | ||
|
||
<h1>Sign up for {{ consent_source.source_name }}</h1> | ||
|
||
<p> | ||
The below form is an example of inheriting from <code>ConsentCreateView</code> which | ||
uses the <code>EmailConsentForm</code>. In your own application, you can make | ||
similar patterns and it's encouraged that you extend one of these two classes. | ||
</p> | ||
|
||
<form method="POST"> | ||
|
||
{% csrf_token %} | ||
|
||
<table> | ||
{{ form.as_table }} | ||
</table> | ||
|
||
<p> | ||
<button type="submit">Send</button> | ||
</p> | ||
|
||
</form> | ||
|
||
{% endblock %} |
Empty file.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
from django import template | ||
from django_consent import models | ||
|
||
register = template.Library() | ||
|
||
|
||
@register.simple_tag | ||
def consent_sources(): | ||
return models.ConsentSource.objects.all() |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
from django.urls import path | ||
|
||
from . import views | ||
|
||
|
||
app_name = "newsletter" | ||
|
||
|
||
urlpatterns = [ | ||
path("", views.Index.as_view(), name="index"), | ||
path( | ||
"signup/<int:source_id>/", | ||
views.ConsentCreateView.as_view(), | ||
name="signup", | ||
), | ||
path( | ||
"signup/<int:source_id>/confirmation/", | ||
views.ConsentConfirmationSentView.as_view(), | ||
name="signup_confirmation", | ||
), | ||
] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,32 @@ | ||
from django.urls.base import reverse | ||
from django.views.generic.base import RedirectView | ||
from django_consent import models | ||
from django_consent.views import ConsentConfirmationSentView | ||
from django_consent.views import ConsentCreateView | ||
|
||
|
||
class Index(RedirectView): | ||
|
||
permanent = False | ||
|
||
def get_redirect_url(self, *args, **kwargs): | ||
source = models.ConsentSource.objects.all().first() | ||
if not source: | ||
source = models.ConsentSource.objects.create( | ||
source_name="Auto-created default newsletter" | ||
) | ||
return reverse("newsletter:signup", kwargs={"source_id": source.id}) | ||
|
||
|
||
class ConsentCreateView(ConsentCreateView): | ||
template_name = "signup.html" | ||
|
||
def get_success_url(self): | ||
return reverse( | ||
"newsletter:signup_confirmation", | ||
kwargs={"source_id": self.consent_source.id}, | ||
) | ||
|
||
|
||
class ConsentConfirmationSentView(ConsentConfirmationSentView): | ||
pass |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the really sloppy part. This should be a proper data migration. The /newsletter/ redirect is perhaps useful, but more likely completely useless :)