Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Troubleshooting documentation: simpler mimetype workaround for .js file #2047

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

blep
Copy link

@blep blep commented Dec 30, 2024

Description

Updated Troubleshooting documentation:

  • Added an introduction advising users to check the developer console log for errors.
  • Provided an example of an error message in the developer console log for an incorrect MIME type for a .js file.
  • Provided a simple solution to fix the incorrect MIME type for a .js file that does not require an O.S. level change.
  • Restructured the existing MIME type documentation to improve readability.

Fixes #2046 (issue)

Checklist:

  • I have added the relevant tests for this change.
  • I have added an item to the Pending section of docs/changes.rst.

@blep blep changed the title Simple mimetype workaround Updated Troubleshooting documentation: simpler mimetype workaround for .js file Dec 30, 2024
Copy link
Member

@tim-schilling tim-schilling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a big fan of putting the python workaround before the more correct, fix your OS configuration, solution, but I can live with it. It suggests that's our recommended approach and if it is, we should change how the library works. I'm unsure if we want to do that, so that's why I'm not sold on the order.

That said, the rest of the changes are excellent, so I'm overall really happy to have this in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation: simplify troubleshooting of incorrect mime types for .js static files
2 participants