Correct RENDER_PANELS functionality and when enabled disable HistoryPanel #1440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1440 +/- ##
==========================================
+ Coverage 86.51% 86.58% +0.07%
==========================================
Files 35 35
Lines 1861 1864 +3
Branches 262 262
==========================================
+ Hits 1610 1614 +4
+ Misses 180 178 -2
- Partials 71 72 +1
Continue to review full report at Codecov.
|
tim-schilling
force-pushed
the
render-panels-rework
branch
from
1b2b044 to
5bb7626
Compare
matthiask
reviewed
Jan 23, 2021
docs/changes.rst
Outdated
Comment on lines
12
to
16
| * ``HistoryPanel`` will be disabled when ``RENDER_PANELS`` is ``True`` | ||
| or if it's not set, but the server is running with multiple processes. | ||
| * Fixes ``RENDER_PANELS`` functionality so that when ``True`` panels are | ||
| rendered during the request and not loaded asynchronously. |
There was a problem hiding this comment.
I have a hard time understanding the first bullet point. The second bullet point should probably use past tense too for consistency.
There was a problem hiding this comment.
Yeah, that's written poorly. I'll fix it.
…anel. The render panels setting used to control whether the toolbar would keep the contents of the panels in the background or render the toolbar on every page. The history panel relies on loading panels in the background. If panels should be rendered on the request, then the history panel is can't/shouldn't work.
tim-schilling
force-pushed
the
render-panels-rework
branch
from
5bb7626 to
765fbd1
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The render panels setting used to control whether the toolbar would keep
the contents of the panels in the background or render the toolbar on
every page. The history panel relies on loading panels in the background.
If panels should be rendered on the request, then the history panel is
can't/shouldn't work.
References #1413