Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add codein #46

Merged
merged 1 commit into from
Sep 24, 2024
Merged

add codein #46

merged 1 commit into from
Sep 24, 2024

Conversation

cunla
Copy link
Member

@cunla cunla commented Sep 24, 2024

Copy link

Terraform plan in terraform
With var files: terraform/production/org.tfvars terraform/production/repositories.tfvars
With variables: github_token = (sensitive value)

Plan: 1 to add, 1 to change, 0 to destroy.
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
+   create
!~  update in-place

Terraform will perform the following actions:

  # github_membership.this["codein"] will be created
+   resource "github_membership" "this" {
+       downgrade_on_destroy = false
+       etag                 = (known after apply)
+       id                   = (known after apply)
+       role                 = "member"
+       username             = "codein"
    }

  # github_repository.this["django-fsm-2"] will be updated in-place
!~  resource "github_repository" "this" {
        id                          = "django-fsm-2"
!~      merge_commit_message        = "BLANK" -> "PR_TITLE"
!~      merge_commit_title          = "PR_TITLE" -> "MERGE_MESSAGE"
        name                        = "django-fsm-2"
#        (35 unchanged attributes hidden)

#        (1 unchanged block hidden)
    }

Plan: 1 to add, 1 to change, 0 to destroy.

📝 Plan generated in Plan org changes and list them in a PR #86

Copy link
Member

@Stormheg Stormheg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

On the side: would it be a good idea to sort all lists alphabetically?


@cunla this terraform update will not have negative consequences I hope?

image

@cunla
Copy link
Member Author

cunla commented Sep 24, 2024

No, though I am not sure how to prevent it from showing..

@cunla
Copy link
Member Author

cunla commented Sep 24, 2024

I like the idea for sorting alphabetically

@cunla cunla merged commit 9b0b2e0 into main Sep 24, 2024
2 checks passed
@cunla cunla deleted the add-codein branch September 24, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

codein
2 participants