Update github actions versions #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tim-schilling
had a problem deploying
to
testpypi
GitHub Actions
Failure
williln
approved these changes
Sep 2, 2024
williln
reviewed
Sep 2, 2024
.github/workflows/release.yml
Outdated
| @@ -49,7 +49,7 @@ jobs: | |||
| name: python-package-distributions | |||
| path: dist/ | |||
| - name: Publish distribution 📦 to PyPI | |||
| uses: pypa/gh-action-pypi-publish@release/v1 | |||
| uses: pypa/gh-action-pypi-publish@release/v1.10.0 | |||
There was a problem hiding this comment.
I don't know why that one CI step is failing but this is the line it's failing on. I double checked and that branch definitely exists. I wondered if we didn't need the @release part, since the tag is available at v1.10.0, but I don't know why it would work in the other steps? TL;DR: I looked into why that one CI step failed and whether that mattered or was a red flag, and I'm not sure.
There was a problem hiding this comment.
Following the documentation they have - it should be release/v1, however, considering release/v* are branch names, it should be release/v1.10
cunla
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.