-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update test matrix to include Django 5 #662
Update test matrix to include Django 5 #662
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #662 +/- ##
=======================================
Coverage 81.79% 81.79%
=======================================
Files 20 20
Lines 912 912
Branches 122 122
=======================================
Hits 746 746
Misses 138 138
Partials 28 28 ☔ View full report in Codecov by Sentry. |
Django 5 doesn't support python 3.7 And it's worth dropping 3.7, though I'm happy to go that in a separate PR if you want to just exclude it from Django 5 in this one. |
418289f
to
531b0c2
Compare
@marksweb Yep, I missed that in the |
@marksweb I'm trying to understand this: I can replicate this issue also on |
@protoroto I think it's an issue with Django CMS' As a result djangocms-picture tries to access the DB before the Django initialisation is finished. I will look at it later today. |
@fsbraun I've seen the fix merged on djangoCMS, tryed locally and now Django5 tests are passing... but I'm not able to trigger the CI here to re-run failed tasks, so whenever you can, let's see if they're passing here too :) |
@protoroto Looks good! 👍 |
Update test matrix to include Django 5
Refs: #661