Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: CI related fix #71

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

ci: CI related fix #71

wants to merge 4 commits into from

Conversation

mrbazzan
Copy link

Description

Fix the Github workflow tests

  • I have opened this pull request against master
  • I have added or modified the tests when changing logic
  • I have followed the conventional commits guidelines to add meaningful information into the changelog
  • I have read the contribution guidelines and I have joined #workgroup-pr-review on
    Slack to find a “pr review buddy” who is going to review my pull request.

@mrbazzan mrbazzan marked this pull request as draft January 20, 2025 22:25
@mrbazzan mrbazzan changed the title WIP: CI fix ci: CI related fix Jan 20, 2025
fsbraun
fsbraun approved these changes Jan 21, 2025
View reviewed changes
Copy link
Member

@fsbraun fsbraun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@fsbraun
Copy link
Member

fsbraun commented Jan 21, 2025

@mrbazzan I removed mptt from the INSTALLED_APPS in the test setup. The current filer does not need it any more.

@mrbazzan
Copy link
Author

@mrbazzan I removed mptt from the INSTALLED_APPS in the test setup. The current filer does not need it any more.

@fsbraun
I went on a "wild goose chase" because I kept getting this 'mppt' error.
Turns out that I had to install django-app-helper>3.3.1 because versions lower
than that kept adding 'mppt' manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fsbraun fsbraun fsbraun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mrbazzan @fsbraun