Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a "auto endianness" function for all listed formats with endianness variants. #78

Merged
merged 2 commits into from
Jul 12, 2021
Merged

Add a "auto endianness" function for all listed formats with endianness variants. #78

merged 2 commits into from
Jul 12, 2021

Conversation

JasonLG1979
Copy link
Contributor

@JasonLG1979 JasonLG1979 commented Jul 11, 2021

No description provided.

This allows a user to call s24_3() and get the proper endianness similar to the other common formats (s16, s24, float and float64).
For the sake of completeness add a "auto endianness" function for all listed formats with endianness variants.
@JasonLG1979 JasonLG1979 changed the title Add a s24_3 function Add a "auto endianness" function for all listed formats with endianness variants. Jul 11, 2021
@JasonLG1979
Copy link
Contributor Author

When checking things with clippy I get:

warning: unknown lint: `clippy::suspicious`
  --> src/lib.rs:17:30
   |
17 | #![warn(clippy::correctness, clippy::suspicious, clippy::perf)]
   |                              ^^^^^^^^^^^^^^^^^^ help: did you mean: `clippy::suspicious_map`
   |
   = note: `#[warn(unknown_lints)]` on by default

warning: unknown lint: `clippy::suspicious`
  --> src/lib.rs:17:30
   |
17 | #![warn(clippy::correctness, clippy::suspicious, clippy::perf)]
   |                              ^^^^^^^^^^^^^^^^^^ help: did you mean: `clippy::suspicious_map`

warning: 2 warnings emitted

According to https://rust-lang.github.io/rust-clippy/master/ clippy::suspicious is not valid. There are however several that start with suspicious?

@diwic
Copy link
Owner

diwic commented Jul 12, 2021

According to https://rust-lang.github.io/rust-clippy/master/ clippy::suspicious is not valid.

It was recently added, maybe you have an old version of clippy? "Suspicious" is indeed a lint group on the page you link to.

@diwic diwic merged commit 1c312d2 into diwic:master Jul 12, 2021
@diwic
Copy link
Owner

diwic commented Jul 12, 2021

Thanks for the patch, merged now :-)

@JasonLG1979
Copy link
Contributor Author

It was recently added, maybe you have an old version of clippy? "Suspicious" is indeed a lint group on the page you link to.

It must have not made to stable yet? I'm just ran rustup update and am on rust version 1.53.0 (53cb7b09b 2021-06-17) and still no dice, same message. Oh, well.

Thanks for the patch, merged now :-)

Yep, I'm glad I could to even do just that little bit. You're certainly welcome. Thank you for the bindings. I've found them pretty useful and fun to play with.

diwic added a commit that referenced this pull request Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants