Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ElemList #130

Merged
merged 1 commit into from
Dec 14, 2024
Merged

Add ElemList #130

merged 1 commit into from
Dec 14, 2024

Conversation

RavuAlHemio
Copy link
Contributor

This allows enumerating control values on a device.

this allows enumerating control values on a device
@diwic
Copy link
Owner

diwic commented Dec 14, 2024

This looks like a well written patch, thanks! My only thought is that one could avoid that extra call to snd_ctl_elem_list_malloc during initialization.

And maybe add some kind of iterator, maybe one that outputs ElemId but I'm not sure if that's a good idea or not.

Anyhow this patch is good enough to be merged as-is and if you want to write follow-up PRs with my suggestions (or your own) you're welcome to do so :-)

Let me know if you need a release. Thanks!

@diwic diwic merged commit 5386746 into diwic:master Dec 14, 2024
1 check passed
@RavuAlHemio
Copy link
Contributor Author

Thanks for the review and merge; I'll contribute additional PRs with your suggestions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants