Add context string to VDAF #1145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should be addressed |
divergentdave
approved these changes
Nov 20, 2024
This was referenced Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the
ctxstring to all the methods that require it. Importantly, this requires updates to theAggregatortrait, among others. My methodology was basically to addctxto the args ofdomain_separation_tag()and propagate the changes out. It's a lot.I kept an empty context string for the benchmarks to minimize the affect on XOF computation.
One note: clippy isn't very happy with how many arguments
Aggregator::prepare_initandPingPongTopology::helper_initializedhave. Open to suggestions here.Completes a subtask of #1122.