Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add preview for article #35

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

VortexExpansion
Copy link
Collaborator

@VortexExpansion VortexExpansion commented May 21, 2024

@VortexExpansion
Copy link
Collaborator Author

@HisashiHasebe san
This is complete.
Keeping this draft until the bugfix on Kuroco is complete. After that is fixed, I will mark this ready for review.

Meanwhile, if you want, you can also review this for other functionalities.

@VortexExpansion
Copy link
Collaborator Author

@HisashiHasebe san
What is your opinion on this ?

Preview page doesn't necessarily need functionality.
Maybe we could just remove the display of the fav_cnt for the preview page or just show a random count of 1 like and merge this.

Is it necessary that preview page must show the exact number of fav_cnt ?

@HisashiHasebe
Copy link
Collaborator

@VortexExpansion
In my opinion, we can wait for https://github.com/diverta/Kuroco-opendev/issues/6518 to fix it.
I don't think the preview feature is urgent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Preview support
2 participants