🗝️ Implement operator and comittee behavior with singing of all transactions #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Velnbur
changed the title
ZamDimon
previously approved these changes
Dec 5, 2024
| "bitcoin-utils", | ||
| "nero-cli", | ||
| # "nero-cli", |
| // fuck, bitcoin, I don't know... | ||
| let mut buff = Vec::new(); | ||
| tx.version.consensus_encode(&mut buff).unwrap(); | ||
| // 0x00.consensus_encode(&mut buff).unwrap(); |
There was a problem hiding this comment.
Are these comments needed?
There was a problem hiding this comment.
In theory, if somebody else will struggle with an encoding of txs in RPC calls. I can remove it
There was a problem hiding this comment.
Just add a comment, "If someone is struggling with..., here is..." or alike
|
Also, make sure to merge #27 to the main branch as it contains a slightly updated paper |
ZamDimon
changed the title
|
@ZamDimon checkout updated doc |
Will shortly do |
Velnbur
force-pushed
the
feature/operator
branch
from
594db4a to
d92a4db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔍 Objective
Implement operator behaviour with all steps required for shared signing of all transactions like it was described in BitVM paper.
🆕 Added
🔧 Fixed/Updated
✅ Checklist
READMEfiles, paper) and Code Comments are updated accordingly.