Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Add constant seeds for integration tests and demo CLI #26

Merged
merged 4 commits into from
Oct 28, 2024

Conversation

Velnbur
Copy link
Collaborator

@Velnbur Velnbur commented Oct 28, 2024

🔍 Objective

As before the behavior of integration tests for "disprove" spending checks was random, the CI sometimes didn't pass as the algorithm may create too large blocks or the script caused the "Stack limit exceeds" error, which wasn't a problem as integration tests only checked the "spending" behavior and bugs will be fixed later.

🆕 Added

Constant seeds for integration tests and demo CLI for distorted states.

✅ Checklist

  • PR title corresponds to the body of changes.
  • PR has a proper label, assignee, and reviewers.
  • Tests that cover the changes are added (if needed).
  • Documentation (README files, paper) and Code Comments are updated accordingly.
  • Code is formatted, all tests pass, and CI shows no errors.

@Velnbur Velnbur added the bug Something is not working label Oct 28, 2024
@Velnbur Velnbur requested a review from ZamDimon October 28, 2024 08:33
@Velnbur Velnbur self-assigned this Oct 28, 2024
@ZamDimon ZamDimon changed the title Add constant seeds for integration tests and demo CLI 🌱 Add constant seeds for integration tests and demo CLI Oct 28, 2024
ZamDimon
ZamDimon previously approved these changes Oct 28, 2024
Copy link
Collaborator

@ZamDimon ZamDimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just make a constant for the magic value

integration-tests/src/taproot.rs Outdated Show resolved Hide resolved
nero-cli/src/cli/actions.rs Show resolved Hide resolved
@Velnbur Velnbur merged commit 45ffe30 into main Oct 28, 2024
5 checks passed
@Velnbur Velnbur deleted the use-seed-in-tests branch October 28, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is not working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants