Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐕 Add BitVM-friendly BigInt Multiplication #22

Merged
merged 12 commits into from
Oct 28, 2024

Conversation

ZamDimon
Copy link
Collaborator

@ZamDimon ZamDimon commented Oct 23, 2024

🔍 Objective

According to the paper, we defined the term BitVM-friendly function. To demonstrate how certain practical functions can be turned into the "friendly" format, we implement the big integer multiplication that is BitVM-friendly.

🆕 Added

  • bitcoin-testscripts folder now contains the friendly package that contains the aforementioned implementation.

🔧 Fixed/Updated

N/A

✅ Checklist

  • PR title corresponds to the body of changes.
  • PR has a proper label, assignee, and reviewers.
  • Tests that cover the changes are added (if needed).
  • Documentation (README files, paper) and Code Comments are updated accordingly.
  • Code is formatted, all tests pass, and CI shows no errors.

@ZamDimon ZamDimon added the feature New feature or request label Oct 23, 2024
@ZamDimon ZamDimon requested a review from Velnbur October 23, 2024 21:35
@ZamDimon ZamDimon self-assigned this Oct 23, 2024
@Velnbur Velnbur force-pushed the feature/friendly-bigint-mul branch from aa09fcd to 0459e50 Compare October 28, 2024 12:03
@Velnbur Velnbur force-pushed the feature/friendly-bigint-mul branch from 089841e to 8a2c14b Compare October 28, 2024 12:19
Velnbur
Velnbur previously approved these changes Oct 28, 2024
Copy link
Collaborator

@Velnbur Velnbur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZamDimon ZamDimon merged commit f805ba9 into main Oct 28, 2024
5 checks passed
@ZamDimon ZamDimon deleted the feature/friendly-bigint-mul branch October 28, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants