Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore #336

Closed
wants to merge 7 commits into from
Closed

Ignore #336

wants to merge 7 commits into from

Conversation

snekROmonoro
Copy link

No description provided.

@snekROmonoro snekROmonoro changed the title Disgoorg master Ignore Mar 8, 2024
@snekROmonoro snekROmonoro deleted the disgoorg-master branch March 8, 2024 21:10
@topi314
Copy link
Member

topi314 commented Mar 8, 2024

you know, if there is an issue you can always make a pr with a fix & I'm gonna happily merge it without you needing to hardfork 💀

@snekROmonoro
Copy link
Author

you know, if there is an issue you can always make a pr with a fix & I'm gonna happily merge it without you needing to hardfork 💀

yeah ik dw LOL, didn't mean to do this pr, it was done by accident

@topi314
Copy link
Member

topi314 commented Mar 8, 2024

then why are you hard forking and not opening a simple pr with a fix

@snekROmonoro
Copy link
Author

snekROmonoro commented Mar 8, 2024

ig i wanted to hard fork it, idek why i had hardforked it in the past

@topi314
Copy link
Member

topi314 commented Mar 8, 2024

  • making those fields omitempty is prob completely valid and just an oversight on our side
  • adding the actual message data to the error message is valid too and we actually wanted to make that change but just forgot about it
  • as for the snowflake changes you want the " quotes to be optional so you can also parse number ids from json?

@snekROmonoro
Copy link
Author

snekROmonoro commented Mar 8, 2024

  • as for the snowflake changes you want the " quotes to be optional so you can also parse number ids from json?

i remember printing out errors where it failed to parse (valid) snowflakes due to " missing

@topi314
Copy link
Member

topi314 commented Mar 8, 2024

then I recommend you open an issue or let us know on our discord so we can look into it instead of doing a yolo

@snekROmonoro
Copy link
Author

will do in the future 👍🏻

@topi314
Copy link
Member

topi314 commented Mar 8, 2024

you can still submit a pr for the other issues if you wish to do so
else I'm just gonna do those changes myself

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants