Merge voice and stage channels into one type #311
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
topi314
reviewed
Sep 11, 2023
There was a problem hiding this comment.
I don't think it's a good idea to merge them
this would be a breaking change now & discord might add new stage specific fields in the future
Each channel type has it's own type except ANNOUNCEMENT_THREAD, PUBLIC_THREAD & PRIVATE_THREAD which are the same. So I think we should keep it like that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the structure of both channel types is identical- this greatly reduces duplicate code with almost no difference for the users.
based on #310