Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DDST-923 : Fixing spreadsheet ingest form states. #119

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Conversation

MorganDawe
Copy link
Contributor

No description provided.

@MorganDawe MorganDawe added the minor Added functionality that is backwards compatible. label Jan 8, 2025
@nchiasson-dgi
Copy link
Contributor

Linting error that occurs is:

FILE: ...est/islandora_spreadsheet_ingest/src/Plugin/migrate/source/Spreadsheet.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 104 | ERROR | [x] Parameter $migration has null default value, but is not
     |       |     marked as nullable.
     |       |     (SlevomatCodingStandard.TypeHints.NullableTypeForNullDefaultValue.NullabilityTypeMissing)
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

Which isn't part of the work being completed above, but can be addressed separately.

@nchiasson-dgi nchiasson-dgi added patch Backwards compatible bug fixes. and removed minor Added functionality that is backwards compatible. labels Jan 8, 2025
@nchiasson-dgi nchiasson-dgi merged commit 06215d4 into main Jan 8, 2025
1 check failed
@nchiasson-dgi nchiasson-dgi deleted the DDST-923 branch January 8, 2025 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Backwards compatible bug fixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants