DEV - MIG - UI Rollback option for CSV Migration Group #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dynac01
commented
May 24, 2024
src/Form/Ingest/Review.php
Outdated
| { | ||
| $migration_group_name = $this->migrationGroupDeriver->deriveName($this->entity); | ||
|
|
||
| $command = sprintf('drush dgi-migrate:rollback --group=%s', escapeshellarg($migration_group_name)); |
There was a problem hiding this comment.
I'm calling the command directly as I was unable to resolve the required in islandora_spreadsheet_ingest.services.yml. Let me know if there are any concerns with this.
dynac01
commented
May 24, 2024
| @@ -10,3 +10,5 @@ dependencies: | |||
| - migrate_plus:migrate_plus | |||
| # We generate links to endpoints migrate_tools defines. | |||
| - migrate_plus:migrate_tools | |||
| # Currently need to access dgi_migrate drush commands | |||
| - dgi_migrate:dgi_migrate | |||
There was a problem hiding this comment.
Adding this since the rollback method used in the solution comes from the dgi_migrate module
…s://github.com/discoverygarden/islandora_spreadsheet_ingest into feature/add-option-to-rollback-full-migrations
dynac01
commented
May 28, 2024
| @@ -145,7 +147,7 @@ public function submitActivation(array &$form, FormStateInterface $form_state) { | |||
| * @param mixed $context | |||
| * A reference to the batch context. | |||
| */ | |||
| public function runBatchOp(MigrationInterface $migration, MigrateBatchExecutable $e, &$context) { | |||
| public function runBatchOp(MigrationInterface $migration, MigrateExecutable $e, &$context) { | |||
There was a problem hiding this comment.
Changing this because both MigrateBatchExecutable and MigrationRollbackBatch extend MigrateExecutable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.