DGI9-477: Fix/drush 12 #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Renamespaced and moving `drush.services.yml` away from the unsupported factory method.
Accidentally dropped it when moving to the other manner of declaring properties via the constructor.
JojoVes
approved these changes
Jan 22, 2024
merge latest from main into fix/drush-12 branch
used phpcbf --standard=Drupal,DrupalPractice
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Presently contains #22, for convenience.
Somewhat of "undoing"/"reverting" some of the thoughts for forward-thinking via the factory method, as Drush 12 elected not to support calling
factorymethod for its "legacy" command discovery using thedrush.services.ymlfiles... so let's just try to "confine" the use of the Drushservices.ymlto the versions for which they're relevant, with the requirements accordingly inlined.The support for Drush's
service.ymlstuff is only slated for removal with Drush 13, so whatever.