[DDST-455] BCELN24MIG-161: Feature/base fields #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Soft-dependency on `base_field_override_ui`. When enabled, should allow mapping of the CSL values via base fields.
Should now have things link back to the CSL Mapping page.
adam-vessey
commented
Aug 1, 2024
islandora_citations.module
Outdated
There was a problem hiding this comment.
Pretty much just:
- renamed the old function away from the hook name
- adjusted its contents to exit early when failing to load the "schema", where much of mess comes from here with reindentation
- readded the old hook to call the new renamed function, as well as two new hooks which call the renamed function to similarly attach when both adding and editing base field overrides.
- slightly simplified the form flow: Putting things directly into
$form['third_party_settings']avoids have to separately handling things on submission.
|
With drupal/base_field_override_ui, i can map the title! Many thanks! |
JojoVes
changed the title
update with latest from main
JojoVes
reviewed
Aug 20, 2024
Comment on lines
+118
to
+121
| new Link( | ||
| $this->t('Add'), | ||
| $add_destination(BaseFieldOverrideUI::getAddRouteInfo($config)), | ||
| ) : |
There was a problem hiding this comment.
An outdated comment is applicable to this section of code so linking for future reference #77 (comment)
And yes I can confirm this is currently not applicable to the list of fields being iterated on, but I see no harm keeping it here in case things get extended/altered to iterate over all base fields rather than just the ones already included in a given content type.
chrismacdonaldw
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.