DGIR-142 : Add thumbnail to manifest #7
Conversation
| if ($object->getEntityTypeId() == 'node') { | ||
|
|
||
| // Load the entity type manager. | ||
| $entity_type_manager = \Drupal::entityTypeManager(); |
There was a problem hiding this comment.
I am not able to add DI for this, it throws an error for circular dependency if I add EntityTypeManagerInterface.
| // It triggers for node and media. Adds thumbnail multiple time. | ||
| // Restricting it for node only. | ||
| if ($object->getEntityTypeId() == 'node') { | ||
|
|
||
| // Load the entity type manager. | ||
| $entity_type_manager = \Drupal::entityTypeManager(); | ||
|
|
||
| // Get term id for Thumbnail Image. | ||
| $term_storage = $entity_type_manager->getStorage('taxonomy_term'); | ||
| $term = $term_storage->loadByProperties([ | ||
| 'name' => 'Thumbnail Image', | ||
| 'vid' => 'islandora_media_use', | ||
| ]); | ||
|
|
||
| // Check if the term is found. | ||
| if (!empty($term)) { | ||
| // Get the term ID. | ||
| $term_id = reset($term)->id(); | ||
| } | ||
|
|
||
| // Get the storage handler for the media entity. | ||
| $media_storage = $entity_type_manager->getStorage('media'); | ||
|
|
||
| // Load a single media entity by properties. | ||
| $media_entities = $media_storage->loadByProperties([ | ||
| 'field_media_use' => $term_id, | ||
| 'field_media_of' => $object->id(), | ||
| ]); | ||
|
|
||
| // Check if a media entity was found. | ||
| if ($media_entities) { | ||
| // Process the single media entity as needed. | ||
| $media_entity = reset($media_entities); | ||
|
|
||
| // Get the file ID from the file field. | ||
| $file_id = $media_entity->get('field_media_image')->target_id; | ||
| $file = $entity_type_manager->getStorage('file')->load($file_id); | ||
|
|
||
| $normalized['thumbnail'] = $this->generateBody($file); | ||
| } | ||
| } |
There was a problem hiding this comment.
This module is not supposed to be aware of any Islandora-isms. Particular bindings to Islandora should be done in the islandora_iiif_presentation_api module.
Also, really kind of seems like this would fit as an event subscriber to the event already dispatched: https://github.com/discoverygarden/iiif_presentation_api/pull/7/files#diff-1f327eb453852f8fd88e233a026b713ce29fdbb5af1418b1f204f466a123e1f7R101-R109
There was a problem hiding this comment.
@adam-vessey I will try to move the implementation to the islandora_iiif_presentation_api module.
From where we can add a thumbnail to the manifest? Is it coming from a Display mode or a different implementation where we are adding required fields?
Sorry if I am not clear above, I am trying to understand the implementation. I would be happy to get on a call to discuss same.
There was a problem hiding this comment.
Is it coming from a Display mode or a different implementation where we are adding required fields?
Unsure, that's what this ticket is (re)defining, no? Would have to go back to the reporter/project owner? Given the original notes referencing islandora_iiif (of which this module is an alternative implementation), I'm unsure of the exact intent.
Really, I'm not sure what this ticket is trying to accomplish, seeming to conflate slow manifest generation with the dereferencing of entities described within the manifest. Sure, allowing it (Mirador) to use IIIF-I to generate thumbnails might consume some cycles on the server CPU side of things; however, given anticipated usage, it could be seen as cache warming (having the Cantaloupe/IIIF-I server acquire the images from which it will be serving tiles, but the IIIF-I-derived thumbnails could also be cached). Trying to use the "Thumbnail image(s)" requires all these additional queries in order to identify the media to provide as a thumbnail, for inclusion in the manifest,
If we wanted to offer a mechanism to provide those related media/file with the http://pcdm.org/use#ThumbnailImage media use, then sure, we can; however, given the whole intent of IIIF in general, I would think instead it might make more sense to generate an explicit thumbnail entry with a IIIF Image API service reference and appropriate dimensions, somewhat similar to https://iiif.io/api/presentation/3.0/#b-example-manifest-response:
"thumbnail": [
{
"id": "https://example.org/iiif/book1/page1/full/80,100/0/default.jpg",
"type": "Image",
"format": "image/jpeg",
"service": [
{
"id": "https://example.org/iiif/book1/page1",
"type": "ImageService3",
"profile": "level1"
}
]
}
],so, to add the thumbnail entries where appropriate, but based upon being derived via the IIIF Image API, effectively just needing to vary the dimensions in some manner:
Something such as:
There was a problem hiding this comment.
Changing code at 'id' => "$base_id/full/full/0/default.jpg", and using IIIF Image API service reference and appropriate dimensions was my first thought. But as per discussion with Chris Mac, and Luke, it should be generated using thumbnail.
https://discoverygarden.atlassian.net/browse/DGIR-142?focusedCommentId=219117
We can discuss DGIR-142 once Luke is back.
Thanks for providing code changes in feedback.
|
No longer required. |
No description provided.