Move the no-op to the base.

discoverygarden · Sep 6, 2023 · bf92e90 · bf92e90
1 parent 9b7b5d0
commit bf92e90
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 16 deletions.
diff --git a/src/Normalizer/V3/FieldItemListNormalizer.php b/src/Normalizer/V3/FieldItemListNormalizer.php
@@ -14,14 +14,6 @@ class FieldItemListNormalizer extends NormalizerBase {
    */
   protected $supportedInterfaceOrClass = FieldItemListInterface::class;
 
-  /**
-   * {@inheritDoc}
-   */
-  public function normalize($object, $format = NULL, array $context = []) {
-    // XXX: No-op as other implementers can define what fields to normalize
-    // with a higher priority.
-  }
-
   /**
    * {@inheritDoc}
    */

diff --git a/src/Normalizer/V3/FieldItemNormalizer.php b/src/Normalizer/V3/FieldItemNormalizer.php
@@ -14,14 +14,6 @@ class FieldItemNormalizer extends NormalizerBase {
    */
   protected $supportedInterfaceOrClass = FieldItemInterface::class;
 
-  /**
-   * {@inheritDoc}
-   */
-  public function normalize($object, $format = NULL, array $context = []) {
-    // XXX: No-op as other implementers can define what fields to normalize
-    // with a higher priority.
-  }
-
   /**
    * {@inheritDoc}
    */

diff --git a/src/Normalizer/V3/NormalizerBase.php b/src/Normalizer/V3/NormalizerBase.php
@@ -16,6 +16,14 @@ abstract class NormalizerBase extends SerializationNormalizerBase {
    */
   protected $format = 'iiif-p-v3';
 
+  /**
+   * {@inheritDoc}
+   */
+  public function normalize($object, $format = NULL, array $context = []) {
+    // XXX: No-op fallback. We expect other implementers to define normalizers
+    // with a higher priority.
+  }
+
   /**
    * {@inheritDoc}
    */