D10-9: Safer PHP array destructuring. #18
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exposed with the bump to PHP 8, started throwing warnings due to attempting to use things naively.
https://www.php.net/manual/en/language.types.array.php :
Started popping from our migration code, as we would:
foxml://object/some:pid
foxml://object
, to attempt to assert that the parent is also not writableThinking: ObjectLowLevel adapters should be expected to avoid providing files which would be deletable. The
akubra_adapter
implementation does so... adding in some filters so the "archival" adapter should also.