[DDST-347] Person MADS and TN migrations #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pretty much just copy/pasted the mods process from these places in dgis_nodes and swapped 'mods' for 'mads': - https://github.com/discoverygarden/dgi_migrate/blob/9c2d9b7cfec4b213a7b08a69f98c28c185fea503/modules/dgi_migrate_foxml_standard_mods/migrations/dgis_nodes.yml#L11-L19 - https://github.com/discoverygarden/dgi_migrate/blob/9c2d9b7cfec4b213a7b08a69f98c28c185fea503/modules/dgi_migrate_foxml_standard_mods/migrations/dgis_nodes.yml#L241-L269 I didn't get into the nested values yet, but this simple mapping in the 'name' field is just something I used to test that it is getting values from the MADS within the FOXML.
And I added comments of what's left to help me pick this back up after the weekend.
this mapping wasn't in the ticket description but it's in the mapping spreadsheet
JojoVes
changed the title
website is simple, the alternate names are mapped simply, at least for now, but might not handle multiple alternate names (not sure if that's necessary at the moment?)
Currently getting an error about the media from bceln_person_tn_media not being able to access the file created by bceln_person_tn_file, but it works fine if accessing a pre-existing file. Committing the current messy state of things to share more easily with the team to get help.
I just noticed the space normalization removed expected formatting from the description value and this is a quick adjustment to address that.
JojoVes
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just noticed I mixed up the numbers in my branch name, should be DDST-347, not DDST-374, but I fixed it in the PR title so it should be fine?
The issue mentioned in 899097b ended up being an issue with
shared/default_uidnot being set for the migration group so files were getting ingested as owned by anonymous and then not able to be referenced. That's addressed in https://github.com/discoverygarden/bceln-drupal/pull/43