DEV: Upgrade rubocop-rspec to 3.0.1

discourse · Jun 13, 2024 · 4c551fc · 4c551fc
1 parent c4548bb
commit 4c551fc
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 3 deletions.
diff --git a/rubocop-discourse.gemspec b/rubocop-discourse.gemspec
@@ -2,7 +2,7 @@
 
 Gem::Specification.new do |s|
   s.name = "rubocop-discourse"
-  s.version = "3.8.0"
+  s.version = "3.8.1"
   s.summary = "Custom rubocop cops used by Discourse"
   s.authors = ["Discourse Team"]
   s.license = "MIT"
@@ -13,10 +13,11 @@ Gem::Specification.new do |s|
 
   s.add_runtime_dependency "activesupport", ">= 6.1"
   s.add_runtime_dependency "rubocop", ">= 1.59.0"
-  s.add_runtime_dependency "rubocop-rspec", ">= 2.25.0"
+  s.add_runtime_dependency "rubocop-rspec", ">= 3.0.1"
   s.add_runtime_dependency "rubocop-factory_bot", ">= 2.0.0"
   s.add_runtime_dependency "rubocop-capybara", ">= 2.0.0"
   s.add_runtime_dependency "rubocop-rails", ">= 2.25.0"
+  s.add_runtime_dependency "rubocop-rspec_rails", ">= 2.30.0"
 
   s.add_development_dependency "rake", "~> 13.1.0"
   s.add_development_dependency "rspec", "~> 3.12.0"

diff --git a/rubocop-rspec.yml b/rubocop-rspec.yml
@@ -1,5 +1,6 @@
 require:
   - rubocop-rspec
+  - rubocop-rspec_rails
 
 RSpec/AnyInstance:
   Enabled: false # To be decided
@@ -223,8 +224,15 @@ RSpec/VoidExpect:
 RSpec/Yield:
   Enabled: true
 
-RSpec/Capybara/FeatureMethods:
+RSpec/Dialect:
   Enabled: true
+  PreferredMethods:
+    background: :before
+    scenario:   :it
+    xscenario:  :xit
+    given:      :let
+    given!:     :let!
+    feature:    :describe
 
 RSpecRails/HttpStatus:
   Enabled: true