Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE: Update base image and set default to postgresql 15 #909

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

mwaniki-wairungu
Copy link
Contributor

This updates the default PostgreSQL version to 15.

  • image/base: update default postgres version to 15
  • launcher: bump base image
  • postgres.template.yml: update default version to 15
  • postgres.15.template.yml: current version template

Legacy version templates:

  • postgres.13.template.yml
  • postgres.12.template.yml
  • postgres.10.template.yml
  • postgres.9.5.template.yml

This updates the default PostgreSQL version to 15.

  * image/base: update default postgres version to 15
  * launcher: bump base image
  * postgres.template.yml: update default version to 15
  * postgres.15.template.yml: current version template

Legacy version templates:

  * postgres.13.template.yml
  * postgres.12.template.yml
  * postgres.10.template.yml
  * postgres.9.5.template.yml
@mwaniki-wairungu mwaniki-wairungu marked this pull request as ready for review January 10, 2025 12:11
@tgxworld
Copy link
Contributor

@mwaniki-wairungu The test failure looks legit here.

@mwaniki-wairungu
Copy link
Contributor Author

The test failure looks legit here.

Fixed. The tests are now green.

@tgxworld
Copy link
Contributor

@mwaniki-wairungu Just confirming but did we test on a self-hosted installation that we are able to upgrade from PG 13 to PG 15?

@mwaniki-wairungu
Copy link
Contributor Author

did we test on a self-hosted installation that we are able to upgrade from PG 13 to PG 15?

Yes. The upgrade was successfully tested on a self-hosted site populated with some test data.

@tgxworld
Copy link
Contributor

Yes. The upgrade was successfully tested on a self-hosted site populated with some test data.

Thank you! The changes look good to me 👍

@@ -92,6 +92,7 @@ kernel_min_version='4.4.0'
config_file=containers/"$config".yml
cidbootstrap=cids/"$config"_bootstrap.cid
local_discourse=local_discourse
# TODO: replace base image before merging
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mwaniki-wairungu I just realised a problem you have here. The new base image with PG 15 installed is only built and made available roughly 30 minutes after this commit lands on the main branch. However it is possible for self hosters to be using the new templates before we are able to update the tag in launcher. With that in mind, I think we need some sort of conditionals in the existing template where we account for the fact that either PG 15 or PG 13 packages may be present in the base image?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

During the PG 13 update, we built a temporary 'placeholder' image from the pg13 branch which was then referenced in launcher. After the changes were merged and the new 'official' image was built, a follow-up commit updated the ref accordingly.

I think we should use a similar approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants