Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEV: Improve support for Ubuntu 20 and Debian 12 #750

Closed
wants to merge 1 commit into from

Conversation

Arkshine
Copy link

@Arkshine Arkshine commented Oct 27, 2023

I've been looking to improve the guide to setting up a development environment and tested the different versions of Ubuntu and Debian (fresh dev installation on cloud hosting)

What does this PR is to fix Ubuntu 20 and Debian 12 installations.
Ubuntu 20 is still officially supported.

In short:

  • Removed the Debian backports usage. The libheif and libaom libraries are not backported.
  • libwebp7 is required in Debian 12.

Debian 10 and Ubuntu 18 are voluntarily ignored in the changes because they are either no longer supported or too old.

Debian

There is no backports installed by default.
E.g. Debian 11:

E: The value 'bullseye-backports' is invalid for APT::Default-Release as such a release is not available in the sources
failed

Looking at the Debian backports:

The libraries are not backported. I don't see any reason to try to use them.

10

The script fails on ImageMagick. The required version doesn't match.

checking for libheif >= 1.4.0... no

# apt show libheif1
Package: libheif1
Version: 1.3.2-2~deb10u1

It's possible to compile from source.
This distribution is fairly old, and It seems to be a good idea to use at least the same version as Discourse (Debian 11)

11

With the change introduced in this PR, it works great.
Discourse uses the bullseyes-slim docker image, and the bullseye-backports is included by default.

12

# cat /etc/issue
Debian GNU/Linux 12 \n \l

With the change introduced in this PR, it works great.

Ubuntu

18

Similar to Debian 10, this can work with some effort. However, the distribution is fairly old and unsupported.
To make it work, you need at least Node 16 and libeom/heif compiled from the source.
We can skip it.

20

With the change introduced in this PR, it works great.

22

It works great as it is.

@CvX CvX requested a review from oblakeerickson October 27, 2023 08:14
@Arkshine Arkshine force-pushed the add-ubuntu20-support branch from 084f614 to 8a38483 Compare November 6, 2023 21:53
@Arkshine Arkshine changed the title DEV: Add support for Ubuntu 20.04 DEV: Add support for Ubuntu 20 and Debian 12 Nov 6, 2023
@Arkshine Arkshine changed the title DEV: Add support for Ubuntu 20 and Debian 12 DEV: Improve support for Ubuntu 20 and Debian 12 Nov 6, 2023
@Arkshine
Copy link
Author

Arkshine commented Nov 6, 2023

I made an update. I tested Debian 10, 11, and 12, and this PR improves support for Ubuntu 20 and now Debian 12.
The first message should be more descriptive.

EDIT: sorry for the unnecessary noise, I wanted to rename the branch.

@Arkshine Arkshine closed this Nov 6, 2023
@Arkshine Arkshine deleted the add-ubuntu20-support branch November 6, 2023 22:04
@Arkshine Arkshine restored the add-ubuntu20-support branch November 6, 2023 22:06
@Arkshine Arkshine reopened this Nov 6, 2023
@Arkshine
Copy link
Author

The build failure doesn't seem related to this PR. 🤔 It errors with:

#10 5.898 Couldn't connect to Redis
#10 5.930 rake aborted!
#10 5.930 Redis::CannotConnectError: Error connecting to Redis on localhost:6379 (Errno::EADDRNOTAVAIL) (Redis::CannotConnectError)

@discoursebot
Copy link

This pull request has been mentioned on Discourse Meta. There might be relevant details there:

https://meta.discourse.org/t/install-discourse-on-ubuntu-or-debian-for-development/14727/675

@discoursebot
Copy link

This pull request has been mentioned on Discourse Meta. There might be relevant details there:

https://meta.discourse.org/t/install-discourse-on-ubuntu-or-debian-for-development/14727/678

@tgxworld
Copy link
Contributor

Thank you for the PR here and this has been addressed in 21a0351.

@tgxworld tgxworld closed this Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants