Skip to content

Commit

Permalink
DEV: Fix broken ARM64 build (#745)
Browse files Browse the repository at this point in the history
Why this change?

The `docker tag discourse/base:aarch64-slim localhost:5000/discourse/base:aarch64-slim
` command broked in 0c93b22 because
there is no `aarch64-slim` image being built. Instead, the `ruby
auto_build.rb base_slime_64` command builds an image with the
`discourse/base:build_slim_arm64` tag.

What does this change do?

This change removes the tagging command because it is pointless for us
to tag it.
  • Loading branch information
tgxworld authored Oct 17, 2023
1 parent 0c93b22 commit c29cba7
Showing 1 changed file with 2 additions and 8 deletions.
10 changes: 2 additions & 8 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ on:
- main
pull_request:
schedule:
- cron: '0 0 * * *'
- cron: "0 0 * * *"

concurrency:
group: build-${{ format('{0}-{1}', github.head_ref || github.run_number, github.job) }}
Expand Down Expand Up @@ -122,11 +122,6 @@ jobs:
aarch64:
runs-on: ubuntu-latest
needs: base
services:
registry:
image: registry
ports:
- 5000:5000
steps:
- uses: actions/checkout@v3
with:
Expand All @@ -139,11 +134,10 @@ jobs:
- name: build slim image
run: |
cd image && ruby auto_build.rb base_slim_arm64
docker tag discourse/base:aarch64-slim localhost:5000/discourse/base:build_slim_arm64
- name: tag slim image as release
working-directory: image/base
run: |
docker tag discourse/base:aarch64-slim discourse/base:aarch64
docker tag discourse/base:build_slim_arm64 discourse/base:aarch64
- name: Print summary
run: docker images discourse/base
- name: push to dockerhub
Expand Down

0 comments on commit c29cba7

Please sign in to comment.