Skip to content
This repository has been archived by the owner on Jul 12, 2023. It is now read-only.

Fix music bot example #237

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Fix music bot example #237

wants to merge 4 commits into from

Conversation

conr
Copy link

@conr conr commented Nov 26, 2021

Fixes for a bunch of Typescript errors in the music bot example.

@@ -2,7 +2,6 @@
"extends": "../../tsconfig.json",
"compilerOptions": {
"baseUrl": ".",
"outDir": "dist",
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already included in the parent tsconfig.json https://github.com/discordjs/voice/blob/main/tsconfig.json#L29

Comment on lines +51 to +54
output: '-',
quiet: true,
format: 'bestaudio[ext=webm+acodec=opus+asr=48000]/bestaudio',
limitRate: '100K',
Copy link
Author

@conr conr Nov 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Types for the flags were added to youtube-dl-exec in this commit.

@almeidx
Copy link
Member

almeidx commented Nov 26, 2021

Should probably bump youtube-dl-exec to the latest version.
And while you're at it, why not bump typescript to the latest version as well instead of 4.4?

@conr
Copy link
Author

conr commented Nov 26, 2021

@almeidx Good call. Updated 👍🏻

@conr
Copy link
Author

conr commented Dec 10, 2021

@iCrawl Is this good to go?

@codecov
Copy link

codecov bot commented Dec 12, 2021

Codecov Report

Merging #237 (fb1aa78) into main (3dabc30) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #237   +/-   ##
=======================================
  Coverage   73.65%   73.65%           
=======================================
  Files          21       21           
  Lines         911      911           
  Branches      227      221    -6     
=======================================
  Hits          671      671           
  Misses        238      238           
  Partials        2        2           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3dabc30...fb1aa78. Read the comment docs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants