New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing sorcha-addons unit tests #1011

Merged

mschwamb merged 1 commit into dirac-institute:main from astronomerritt:addons-test-fix

Sep 3, 2024

Contributor

astronomerritt commented Sep 3, 2024

Fixes #995.

Implemented Drew's fix for two unit tests failing when sorcha-addons is installed.
Split off from PR Including code to process a subset of inputs, fixing unit tests #998 so it can be merged by itself.
All unit tests pass on my machine.

There shouldn't be any need to change PR #998 but I'll double-check once this is merged.

Review Checklist for Source Code Changes

Does pip install still work?
Have you written a unit test for any new functions?
Do all the units tests run successfully?
Does Sorcha run successfully on a test set of input files/databases?
Have you used black on the files you have updated to confirm python programming style guide enforcement?


          Fixing unit tests

290ba94

astronomerritt requested a review from mschwamb

September 3, 2024 12:25

astronomerritt marked this pull request as ready for review

September 3, 2024 12:26

mschwamb approved these changes

View reviewed changes

mschwamb merged commit ed8e3cc into dirac-institute:main

2 of 7 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet