Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Fenrir Translations source #2540

Merged
merged 1 commit into from
Jan 7, 2025
Merged

Conversation

kardigun
Copy link
Contributor

@kardigun kardigun commented Jan 5, 2025

No description provided.

@dipu-bd dipu-bd merged commit c9f3c8b into dipu-bd:dev Jan 7, 2025
0 of 4 checks passed
@dipu-bd
Copy link
Owner

dipu-bd commented Jan 7, 2025

The template looks very similar to MadaraTemplate. I have merged this since it is working, but can you check if using the template works.

from lncrawl.templates.madara import MadaraTemplate

class FenrirTranslationsCrawler(MadaraTemplate):
    base_url = ["https://fenrirtranslations.com/"]

@kardigun
Copy link
Contributor Author

kardigun commented Jan 7, 2025

You're right, this could be implemented based on MadaraTemplate with some adjustment for chapters selection to skip paid chapters (or actually chapters linking to the novel page itself).
Please tell me if using the template is preferred, I would then create another PR to fix.

@kardigun kardigun deleted the fenrirtranslations branch January 7, 2025 12:47
@dipu-bd
Copy link
Owner

dipu-bd commented Jan 7, 2025

yes, using a template is preferred. it is easier for maintenance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants