add SendTransaction in dipperin external api and fix log tips #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Min65535
commented
Feb 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
name: pull request
about: add SendTransaction in dipperin external api and fix log tips
title: 'add func and fix log tips'
labels: 'add func and fix log tips'
assignees: 'min65535'
Short change description
A short one-line summary of the change, prefixed by the primary affected package.
A rule of thumb is that it should be written so to complete the sentence "This change modifies Dipperin-core to add SendTransaction in dipperin external api and fix log tips." That means it does not start with a capital letter, is not a complete sentence, and actually summarizes the result of the change.
A description of the changes proposed in the pull request
Ex.The random argument should be spread to args. Current code only randomly generates the first argument and the second one is always 0.
A reference to a related issue
The special notation "Fixes #12345" associates the change with issue 12345 in the Go issue tracker. When this change is eventually applied, the issue tracker will automatically mark the issue as fixed.
If the change is a partial step towards the resolution of the issue, uses the notation "Updates #12345".
@mentions of the person or team responsible for reviewing proposed changes
Ex.@Dipperin-core/developer or @Dipperin-core/XXX