Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(example): fixed build error #43

Merged
merged 1 commit into from
Jun 24, 2024
Merged

fix(example): fixed build error #43

merged 1 commit into from
Jun 24, 2024

Conversation

makhnatkin
Copy link
Contributor

This PR fix this error:

> node . 1> build/index.html; open build/index.html
sh: build/index.html: No such file or directory

@makhnatkin makhnatkin requested a review from vsesh June 24, 2024 15:42
makhnatkin
makhnatkin commented Jun 24, 2024
View reviewed changes
.gitignore
@@ -6,5 +6,4 @@ node_modules

index.d.ts
example/package-lock.json
example/build
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

after that, I can return this ignore

makhnatkin
makhnatkin commented Jun 24, 2024
View reviewed changes
example/build/.gitkeep
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

file like here: https://github.com/diplodoc-platform/mermaid-extension/blob/master/example/build/.gitkeep

@makhnatkin makhnatkin merged commit 9f314fb into master Jun 24, 2024
2 checks passed
@makhnatkin makhnatkin deleted the fix-example-build branch June 24, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsesh vsesh vsesh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@makhnatkin @vsesh