Replace separators in paths for Windows users #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
replace '\' to '/'
build/includer.js
Outdated
| @@ -6,7 +6,7 @@ const IN_PATH = path.resolve('src', 'includer'); | |||
| const OUT_PATH = 'includer'; | |||
| const FORMATS = ['cjs', 'esm']; | |||
|
|
|||
| const tsFiles = glob.sync(`${IN_PATH}/**/*.ts`); | |||
| const tsFiles = glob.sync(`${IN_PATH.replace(/\\/g, '/')}/**/*.ts`); | |||
There was a problem hiding this comment.
it seems it would be better if you add a replacement when defining a variable
const IN_PATH = path.resolve('src', 'includer').replace(/\\/g, '/');
There was a problem hiding this comment.
and commit tag should be probably fix:
add separator replacement when defining IN_PATH variable
martyanovandrey
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows paths contain '\' separator. Replace '\' to '/' because includer.js doesn't work correctly with '\' separator in path.