Add Optimism, Base, Metis and Avalanche Info in Common Package #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Jeff-CCH
commented
Oct 6, 2023
•
Jeff-CCH
commented
- changeset
- network info
- router info
Jeff-CCH
changed the title
Jeff-CCH
changed the title
Jeff-CCH
force-pushed
the
feat/support_Base_Metis_Optimism_Avalanche
branch
from
ecd41c8 to
863e1b6
Compare
Jeff-CCH
force-pushed
the
feat/support_Base_Metis_Optimism_Avalanche
branch
from
863e1b6 to
12ea0d9
Compare
chouandy
reviewed
Oct 11, 2023
| "symbol": "WETH", | ||
| "name": "Wrapped Ether" | ||
| }, | ||
| "multicall2Address": "0x091e99cb1C49331a94dD62755D168E941AbD0693", |
There was a problem hiding this comment.
After checking, the contract interface at that address is not Multicall2. It is an optimized version modified by Uniswap. Since Multicall3 is backward compatible with Multicall2, we could use Multicall3 as a substitute for Multicall2 at the address.
There was a problem hiding this comment.
That's pretty weird since the Uniswap team put this address in the Multicall2 address column. Will use the multicall3Address for the multicall2Address.
There was a problem hiding this comment.
It seems like Uniswap has already transitioned to using its own Multicall. I think I should find time to refine how we retrieve quotes from their interface.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.