Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix no-std CI build configuration #1454

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

waywardmonkeys
Copy link
Contributor

  • Stop using xargo and just use a regular cargo build.
  • Use stable rather than nightly as that works with cargo.
  • Update from actions-rs/toolchain for this job to dtolnay/rust-toolchain as the actions-rs action is unmaintained.
  • Switch from x86_64-unknown-linux-gnu to x86_64-unknown-none as that is a 64 bit target that has no std lib.
  • Keep the 32 bit ARM target testing to keep that coverage.
  • Fix the rand-no-std test to pass that feature to the build.

* Stop using `xargo` and just use a regular `cargo` build.
* Use `stable` rather than `nightly` as that works with `cargo`.
* Update from `actions-rs/toolchain` for this job to
  `dtolnay/rust-toolchain` as the `actions-rs` action
  is unmaintained.
* Switch from `x86_64-unknown-linux-gnu` to `x86_64-unknown-none`
  as that is a 64 bit target that has no `std` lib.
* Keep the 32 bit ARM target testing to keep that coverage.
* Fix the `rand-no-std` test to pass that feature to the build.
@sebcrozet sebcrozet merged commit efb3ada into dimforge:main Oct 29, 2024
11 checks passed
@sebcrozet
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants