-
Notifications
You must be signed in to change notification settings - Fork 1
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat: Node 18 testing in GH actions (#145)
* feat: Node 18 testing in GH actions * Remove cache step and use cache from node action
- Loading branch information
1 parent
1450550
commit bceadf1
Showing
1 changed file
with
2 additions
and
8 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -10,7 +10,7 @@ on: | |
node_matrix: | ||
description: 'A JSON string of an array of Node versions to run tests on' | ||
type: string | ||
default: '["16.x", "17.x"]' | ||
default: '["16.x", "17.x", "18.x"]' | ||
|
||
# Only upload coverage report for one of the Node versions in the matrix. | ||
# Must be present in the matrix. E.g., "17.x" | ||
|
@@ -42,17 +42,11 @@ jobs: | |
with: | ||
persist-credentials: ${{ env.HAVE_GITHUB_PAT != 'true' }} | ||
|
||
- uses: actions/cache@v3 | ||
with: | ||
path: ~/.npm | ||
key: ${{ runner.os }}-node-${{ matrix.node-version }}-${{ hashFiles('**/package-lock.json') }} | ||
restore-keys: | | ||
${{ runner.os }}-node-${{ matrix.node-version }}- | ||
- name: Use Node.js ${{ matrix.node-version }} | ||
uses: actions/setup-node@v3 | ||
with: | ||
node-version: ${{ matrix.node-version }} | ||
cache: 'npm' | ||
|
||
- name: Set Private Access Token (if present) | ||
run: git config --global url."https://${{secrets.GITHUB_PAT}}@github.com/".insteadOf ssh://[email protected]/ | ||
|