Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trak wrapper #106
Trak wrapper #106
Changes from 5 commits
de348f0
67c09bd
9dfd4b9
b5eecd7
8867dc7
357866c
25280fe
09ad3a5
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are we sure this is a robust way to count parameters?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is very nitpicky, but I'm sure there are way more elegant ways to do 43 - 47
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should also count parameters of a given parameter loader, not necessarily all the parameters in the model. User may want to only consider final layer etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this not outside of the class?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, forgot to talk about this during our meeting. For this, I think along these lines: the only reason for that projector_cls dictionary to exist, is that it let's us quickly implement if statements. So if we were looking at it in terms of where it is used, why we have that dictionary, it's only a local thing for this explainer so I wouldn't define it outside the class..
of course, nothing changes practically if we define it outside so i let you decide if you definitely want to keep it outside, or are convinced by my explanation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shall we make
exp_name
an argument to init? it can betest
by default.also I didn't look much into the trak library - but does it make more sense to do start_scoring_checkpoint in init as well? it might be doing something intense that we don't want to repeat every time we explain, for all I know
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am assuming we decided to keep this as is. you can make the change very quickly if you decide to do it.