-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BugFix: Issue #361: Fix wrong computed properties behaviour on updates #362
Open
arjunrajnetapp
wants to merge
31
commits into
dikhan:master
Choose a base branch
from
instaclustr:bugfix/fix-wrong-computed-properties-behaviour-on-updates
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
BugFix: Issue #361: Fix wrong computed properties behaviour on updates #362
arjunrajnetapp
wants to merge
31
commits into
dikhan:master
from
instaclustr:bugfix/fix-wrong-computed-properties-behaviour-on-updates
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s from the API with integer types of local state.
…ested properties and optional properties
…erty to terraform utils terraformutils package
…ted objects as single item lists
… terraform compliant name vs API property name
… already pruned + fixed test
…staclustr-releases
… to unexpected values on move
…staclustr-releases # Conflicts: # go.mod # go.sum
…/instaclustr-releases
# Conflicts: # go.mod # go.sum
…d with default values on property omission during create
…staclustr-releases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this Pull Request solve?
Closes #361
Apologies for the large PR size, I've had to base it off of previous PRs #347 and #353 as I couldn't fix the problem without incorporating changes from those PRs. Happy to consider this to be blocked by those PRs, or could just address everything on this one and close the others.
Type of change
What type of change does your code introduce to the provider? Please put an
x
(w/o heading/trailing white spaces) in the boxes that apply:Checklist
Please put an
x
(w/o heading/trailing white spaces) in the boxes that apply:make test-all
[FeatureRequest: Issue #X] <PR Title>
[BugFix: Issue #X] <PR Title>
[TechDebt: Issue #X] <PR Title>
[NewRelease] vX.Y.Z
Checklist for Admins