Make sure to display old deprecated instance sizes

[lauhon]

Hi,

I'm not entirely sure if this is valid. But I noticed that the old instance slugs still work, but are not part of the schema.

My idea is to display them, but as deprecated. This would be great for the project Im working on, because we still use those old slugs and would benefit from them being present in the API spec.

[lauhon]

Hey @loosla, thanks for helping me out by approving the actions and merging main.

Could you check out the failing pipeline?
It seems to have nothing to do with the file I changed, so I'm not sure how to fix it.

[andrewsomething]

Hi @lauhon,

Thanks for the PR. I've made some suggestions inline.

Admittedly, I am a bit reluctant about this one. We are intentionally discouraging new usage of these plans as they will go away at some point in the future. Though marking them as deprecated and adding a bit of a disclaimer should be a good compromise.

[andrewsomething]

Adding old_instance_size_slug here makes this appear as a separate attribute that could be set in an API request.

[lauhon]

Thanks a lot @andrewsomething!

I applied your suggestions :)

[andrewsomething]

👍 LGTM, thanks for applying the changes!