uncheckedHsx + customHsx

[kodeFant]

I think this works.Probably necessary with eyes of @mpscholten to verify the code is not too crazy. I had some AI help 😄

• Doesn't parse attribute names or tag names
• Properly checks for closing tags
• Still allows for certain tags like <hr> and <br> to not be explicitly closed, but disallows any other so we force users to close everything else. Makes the most sense I think
• Allows for interpolation of attributes and values

[kodeFant]

Nah, sorry to say this is not yet great. It seems like the validation stuff works, but the rendering is just awful

[kodeFant]

@mpscholten, WDYT of latest changes?

1. I also added tests to ParserSpec. For QQSpec.hs, it seems the only viable option is to duplcate all the testst for uncheckedHsx? Should I do that?

2. It might be that I gained some courage to attempt the whitelisting thing also now, following the same approach, replacing the checkMarkup with a record type:

data HsxSettings = HsxSettings {
    checkMarkup :: Bool,
    additionalTagNames :: [Text],
    additionalAttributeNames :: [Text]
}

and then for example a custom hsx would look something like this:

customHsx :: [Text] -> [Text] -> QuasiQuoter
customHsx additionalTagNames additionalAttributeNames = QuasiQuoter {
        quoteExp = quoteHsxExpression (HsxSettings True additionalTagNames additionalAttributeNames),
        quotePat = error "quotePat: not defined",
        quoteDec = error "quoteDec: not defined",
        quoteType = error "quoteType: not defined"
    }

Maybe also the additionalTagNames and additionalAttributeNames should be wrapped in a newtype though, but not sure, maybe it's too much:

newtype AdditionalTags = AdditionalTags [Text]
newtype AdditionalAttributes = AdditionalAttributes [Text]

and then

customHsx (AdditionalTags  ["book", "title", "content"]) (AdditionalAttributes ["non-standard", "hrefplusplus"])

[kodeFant]

I went ahead with the whole thing and added customHsx in the latest commit.

All of what we talked about in #2009 should be solved now.

Example declaration in a separate Helper module:

module Application.Helper.CustomHsx where

import IHP.HSX.QQ (customHsx, AdditionalTags(..), AdditionalAttributes(..))
import Language.Haskell.TH.Quote


myHsx :: QuasiQuoter
myHsx = customHsx 
            (AdditionalTags ["test", "weird"]) 
            (AdditionalAttributes ["strange", "attribute"])

[kodeFant]

Can now be tested like this:

module Application.Helper.CustomHsx where

import IHP.Prelude
import IHP.HSX.QQ (customHsx)
import IHP.HSX.Parser
import Language.Haskell.TH.Quote
import qualified Data.Set as Set

myHsx :: QuasiQuoter
myHsx = customHsx 
                (HsxSettings 
                    { checkMarkup = True,
                      additionalTagNames = Set.fromList ["test", "weird"],
                      additionalAttributeNames = Set.fromList ["strange", "attribute"]
                    }
                )

[mpscholten]

Looks good to me now 👍 Thanks!

[amitaibu]

Thanks! Maybe worth adding a short section in the docs?

[kodeFant]

@amitaibu Added some docs in the ihp-hsx README and pasted the same text into the IHP Guide

[mpscholten]

Thanks 👍