Save only the relative path of the filename for StaticDirStorage

[amitaibu]

fixes #1989

[amitaibu]

I still need to verify it locally, but looking here:

ihp/IHP/FileStorage/ControllerFunctions.hs

Lines 223 to 229 in a58f7a0

	createTemporaryDownloadUrlFromPathWithExpiredAt :: (?context :: context, ConfigProvider context) => Int -> Text -> IO TemporaryDownloadUrl
	createTemporaryDownloadUrlFromPathWithExpiredAt validInSeconds objectPath = do
	publicUrlExpiredAt <- addUTCTime (fromIntegral validInSeconds) <$> getCurrentTime
	case storage of
	StaticDirStorage -> do
	let frameworkConfig = ?context.frameworkConfig
	let url = frameworkConfig.baseUrl <> "/" <> objectPath

It looks like it's expecting objectPath to be relative. So Likely this is also a bug fix.

[amitaibu]

@mpscholten 👋 I suspect this line, with the error, causes the error I get when running the test

How can I make it work? (Copied from here)

[mpscholten]

That GHC error is unrelated to the error call. I just pushed a workaround via 66518de to master (appartently the INLINE triggers the bug in GHC, but chaging that to an optional inline via INLINABLE not triggers the bug). Can you sync with master and then check again?

[amitaibu]

Thanks. I think now it hits that error

[mpscholten]

You can use IHP.FrameworkConfig.withFrameworkConfig to get a framework config object, like this:

    let withFrameworkConfig = IHP.FrameworkConfig.withFrameworkConfig (pure ())
    describe "createTemporaryDownloadUrlFromPathWithExpiredAt" $ do
        it "returns baseUrl concatenated with objectPath when objectPath does not start with http:// or https://" $ do
            withFrameworkConfig \frameworkConfig -> do
                context <- createControllerContext frameworkConfig
                let ?context = context
                let objectPath = "static/test.txt"
                temporaryDownloadUrl <- createTemporaryDownloadUrlFromPath objectPath

                temporaryDownloadUrl.url `shouldBe` "http://localhost:8000/static/test.txt"

And then use the frameworkConfig passed to createControllerContext instead of the error call

[amitaibu]

With this I get

  ./IHP/Prelude.hs:92:17: 
  1) IHP.FileStorage.ControllerFunctions.storeFileWithOptions returns the objectPath without the baseUrl
       uncaught exception: ErrorCall
       Could not find FileStorage in config. Did you call initS3Storage from your Config.hs?
       CallStack (from HasCallStack):
         error, called at ./IHP/Prelude.hs:92:17 in main:IHP.Prelude

While trying to figure how to pass a config with the initStaticDirStorage (didn't figure yet), I found aroundAll (withIHPApp WebApplication config) do

Maybe we should use that? (If so, not sure how 😅 )

[amitaibu]

I was able to init the storage here

[amitaibu]

Tests passing locally ✌️

[mpscholten]

Looks good, thanks 👍