Allow overriding the logger in the controller context #1923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amitaibu
reviewed
Feb 28, 2024
| -- The following hack is bad, but allows us to override the logger using 'putContext' | ||
| -- The alternative would be https://github.com/digitallyinduced/ihp/pull/1921 which is also not very nice | ||
| -- | ||
| -- This design mistake should be fixed in IHP v2 |
There was a problem hiding this comment.
Out of curiosity, what's your idea for fixing on v2?
There was a problem hiding this comment.
No specific idea yet. We kind of want to make controller context less mutable (e.g. we could change the type signature from initContext to the type signature of mapContext in the other branch. That way it's more functional, which would avoid this issue)
IHP/Controller/Context.hs
Outdated
Comment on lines
146
to
147
| getField context@(FrozenControllerContext { customFields }) = fromMaybe context.frameworkConfig.logger (TypeMap.lookup @Logger) | ||
| getField context = (unsafePerformIO (freeze context)).logger |
There was a problem hiding this comment.
I think it's worth adding some comment to what we're doing here -- it's not clear to me
There was a problem hiding this comment.
Just added more comments, hope this clears it a bit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.