Update makefile section in tailwindcss #1890
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amitaibu
commented
Jan 10, 2024
| tailwind-dev: | ||
| tailwindcss -c tailwind/tailwind.config.js -i ./tailwind/app.css -o static/app.css --watch | ||
| # Install npm packages. | ||
| node_modules: |
There was a problem hiding this comment.
Likely because you already have a node_modules directory. Can you delete it and try again?
There was a problem hiding this comment.
I have tried again (using this PR), but the same message
| tailwindcss -c tailwind/tailwind.config.js -i ./tailwind/app.css -o static/app.css --watch | ||
| # Install npm packages. | ||
| node_modules: | ||
| NODE_ENV=production npm ci |
There was a problem hiding this comment.
Why do we need NODE_ENV=production?
There was a problem hiding this comment.
So it doesn't install devDependencies
| node_modules: | ||
| NODE_ENV=production npm ci | ||
|
|
||
| # We rely on the `node_modules`. So if `node_modules` directory doesn't exist, calling `make tailwind-dev` will trigger `make node_modules`. |
There was a problem hiding this comment.
So if
node_modulesdirectory doesn't exist
As make node_modules didn't work for me I wasn't able to confirm this.
|
@mpscholten some questions ^^ |
amitaibu
commented
Jan 11, 2024
amitaibu
commented
Jan 11, 2024
| static/app.css: | ||
| tailwindcss -c tailwind/tailwind.config.js -i ./tailwind/app.css -o static/app.css --minify | ||
| static/app.css: node_modules | ||
| NODE_ENV=production node_modules/.bin/tailwind -c tailwind/tailwind.config.js -i ./tailwind/app.css -o static/app.css --minify |
There was a problem hiding this comment.
Suggested change
| NODE_ENV=production node_modules/.bin/tailwind -c tailwind/tailwind.config.js -i ./tailwind/app.css -o static/app.css --minify | |
| node_modules/.bin/tailwindcss -c tailwind/tailwind.config.js -i ./tailwind/app.css -o static/app.css --minify |
There was a problem hiding this comment.
AFAIK NODE_ENV=production was needed before purging was automatic
|
Closed in favor of #1905 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.