Add debounce to fsnotify #1882
Merged
Add debounce to fsnotify #1882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amitaibu
reviewed
Jan 1, 2024
ihp.cabal
Outdated
| @@ -105,6 +105,7 @@ common shared-properties | |||
| , with-utf8 | |||
| , ihp-hsx | |||
| , ihp-postgresql-simple-extra | |||
| , auto-update | |||
There was a problem hiding this comment.
Is this related to the debounce?
There was a problem hiding this comment.
Yes the Control.Debounce module is part of that package
There was a problem hiding this comment.
Should we add a comment to indicate it?
amitaibu
reviewed
Jan 1, 2024
ihp.cabal
Outdated
| @@ -105,6 +105,7 @@ common shared-properties | |||
| , with-utf8 | |||
| , ihp-hsx | |||
| , ihp-postgresql-simple-extra | |||
| , auto-update | |||
There was a problem hiding this comment.
Should we add a comment to indicate it?
Not possible without adding latency. We could use https://hackage.haskell.org/package/auto-update-0.1.6/docs/Control-Debounce.html#v:trailingEdge to first cool down and then trigger the reloads. The issue is that this adds latency to every normal single file change |
|
Yeah, I was just reading about the Thanks 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1809