Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tailwind nixpkgs #1839

Merged
merged 10 commits into from
Oct 7, 2023
Merged

Conversation

kodeFant
Copy link
Contributor

@kodeFant kodeFant commented Oct 6, 2023

This updates the guide to use Tailwind CSS (with official plugins like @tailwind/forms) directly via nixpkgs

Notes:

  • I took the liberty of proposing to replace the npm guide with the nix approach. Let me know if there still are compelling reasons to keep the npm guide as well
  • Removed mentions of JIT, since this is default in Tailwind 3
  • autoprefixer is already bundled into the Tailwind CLI, and the postcss package isn't really being used for anything, so this setup should be on full feature parity with the former way

@kodeFant kodeFant marked this pull request as ready for review October 6, 2023 18:31
Copy link
Collaborator

@amitaibu amitaibu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kodeFant I was able to make it work for me 💯 . I've added a few comments for your consideration.

@@ -67,7 +79,6 @@ Create the tailwind configuration file at `tailwind/tailwind.config.js` with the
const plugin = require('tailwindcss/plugin');

module.exports = {
mode: 'jit',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍


Install Tailwind along with PostCSS and some handy libraries via NPM:
Usage:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't thing we need to show all that

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can probably just remove it and just display the command

Guide/tailwindcss.markdown Outdated Show resolved Hide resolved
Guide/tailwindcss.markdown Outdated Show resolved Hide resolved
### Installing Tailwind
```
$ tailwindcss
tailwindcss v3.2.7
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is what I got

Suggested change
tailwindcss v3.2.7
tailwindcss v3.3.3

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am guessing you are running on master, and I am running on v1.1.0.

Maybe not necessary to have any of the output there

Guide/tailwindcss.markdown Outdated Show resolved Hide resolved
Guide/tailwindcss.markdown Show resolved Hide resolved
Copy link
Collaborator

@amitaibu amitaibu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amitaibu amitaibu merged commit 776b19b into digitallyinduced:master Oct 7, 2023
2 checks passed
@amitaibu
Copy link
Collaborator

amitaibu commented Oct 7, 2023

Thanks 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants