Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Enum tests #1835

Merged
merged 2 commits into from
Oct 2, 2023
Merged

Fix Enum tests #1835

merged 2 commits into from
Oct 2, 2023

Conversation

amitaibu
Copy link
Collaborator

@amitaibu amitaibu commented Oct 2, 2023 •
edited
Loading

Oops, Bounded PR was merged before I got to fix the tests 🙈

image

@amitaibu amitaibu changed the title WIP: Fix Enum tests Fix Enum tests Oct 2, 2023
@amitaibu amitaibu requested a review from mpscholten October 2, 2023 12:23
mpscholten
mpscholten approved these changes Oct 2, 2023
View reviewed changes
Copy link
Member

@mpscholten mpscholten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, with the CI broken it's hard to spot this 👍 Hope to have the CI green soon again :)

@mpscholten mpscholten marked this pull request as ready for review October 2, 2023 14:45
@mpscholten mpscholten merged commit e2458d9 into master Oct 2, 2023
2 of 10 checks passed
@mpscholten mpscholten deleted the bounded-tests-fix branch October 2, 2023 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpscholten mpscholten mpscholten approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amitaibu @mpscholten