Suggest users potential contact sources

[MizukiTemma]

Short description

This PR introduces a hint page to help users to create new contacts and replace embedded E-mail addresses and phone numbers with contact cards. This is not an amtomated solution, but I hope it can help and guide users at least. This PR is opened as suggestion of an approach and does not mean to be a finalized something. I'm open to any idea 😸

Proposed changes

• Create a new page "Potential contact data"
• Add a link to it next to the title of contact list with 💡 icon
• In "Potential contact data": List embedded E-mail addresses and phone numbers per page/event/location *1
• In "Potential contact data": List related contacts (either E-mail or phone number matched) too as suggestion

*1: not per translation, as the list would be then too long with a lot of duplicates. All E-mail addresses and phone numbers in all languages of the page/event/poi will be shown but without duplicate even if any of them appears multiple times in multiple of translations.

Note: I have decided to show targets (E-mail addresss, phone numbers) per content, not contents per target (where each E-mail address and phone number is used), because 1) users probably need context why and where those contact informations are given while replacing them with contact cards or creating a new contact and 2) the later view is almost the same with broken link list.

Side effects

Those points are still in progress and will be worked on, once this approach receives agreement from the team and we decide for details.

• Naming, sentences, explanations and their translation, appearance, design etc.
• Queries in the view
• Preview of the page/event/location and/or link to their form (👁️ and ✏️ icons next to content title)
• How to show suggested contact (maybe as contact card, or simply __str__ with link?)
• Maybe: add a button for contact creation per ajax/pop-up under the suggested contact to create a new contact, so users can create a new one while seeing which E-mal address and phone numers are used for which topic.

Resolved issues

Fixes: #2957

---

Pull Request Review Guidelines

[MizukiTemma]

@osmers
Currently it looks like this

Users are expected to click here

No suggestion is shown if no contact targets are found

If any detected, related contacts are shown

[osmers]

Users are expected to click here

I would not have guessed that :D somehow the sentence leads me to believe that there is an information page (e.g. from the wiki) behind it, that explains, where I can use contacts) - maybe we can rephrase it?
E.g. Vorschläge für Kontakte, die Sie erstellen können @nikolahoff maybe for a better phrasing that suggests to users that they can find suggestions on how to use the feature there

No suggestion is shown if no contact targets are found

Can you change it to Telefonnummer? :)

If any detected, related contacts are shown

So this only shows up with they already have a contact created, that uses the same information, right?
Is it feasible or even useful that maybe we show them lists of contact details that are in the content, but don't have a contact yet? Probably additionally to what you have already done here....

Edit: Maybe you are already planning the last point, not sure. Bcs that's what I understood from the description...

[JoeyStk]

I would not have guessed that :D somehow the sentence leads me to believe that there is an information page (e.g. from the wiki) behind it, that explains, where I can use contacts) - maybe we can rephrase it?

I agree with @osmers. I also only got it because of your explanation. My first suggestion to rephrase it would be simply:
"Analysis of content for existing contacts in" and for the German translation "Inhaltsanalyse für bestehende Kontaktdaten". What do you think about? :)

[JoeyStk]

First of all thank you very much for this PR! It's a cool feature and a cool step forward! I'm truely grateful that you took on such a big task.

For now I only tested the usability of the feature and didn't have a look at the code yet. Here are a few things, that I noticed, that didn't make sense to me (yet).

1. I'm a bit unsure how to interpret the icons
   . To me they weren't clickable. I would have expected that the eye would take me to page/event/poi that contains the found contact. For the pencil I would have expected that it takes me to an editing page of some sort. What was your intention on adding the icons? :)

2. When I copied the source code of this page (test cms, app), I got the following result in the contact detection. To be honest, as a user I'm not totally sure what to do with this information next. Maybe we can think of something to guide the user more towards a goal?

3. Maybe this goes to far and is not yet part of this PR or of the tool altogether, but when I copied the source code of this page (app), I expected for the tool to find the keyword "Kontakt" and maybe extract some kind of information for a contact from it

4. This goes back a little bit to 2). I think I would have expected a button or something to convert the found phone number or email to a contact, if there is no contact found which already contains this information. A wonderful bonus addition would be, if on click on the button the information already gets transferred to the form and would be filled out already.

These are my thoughts on this feature for now :) I hope they are helpful in some form or another :)

[osmers]

4. This goes back a little bit to 2). I think I would have expected a button or something to convert the found phone number or email to a contact, if there is no contact found which already contains this information. A wonderful bonus addition would be, if on click on the button the information already gets transferred to the form and would be filled out already.

Yeah, this is what I meant with my last point as well :) would make a lot of sense to make creating new contacts much easier and faster.

[MizukiTemma]

No suggestion is shown if no contact targets are found

Can you change it to Telefonnummer? :)

Done, thank you @JoeyStk

[MizukiTemma]

Users are expected to click here

I would not have guessed that :D somehow the sentence leads me to believe that there is an information page (e.g. from the wiki) behind it, that explains, where I can use contacts) - maybe we can rephrase it?

I agree with @osmers. I also only got it because of your explanation. My first suggestion to rephrase it would be simply: "Analysis of content for existing contacts in" and for the German translation "Inhaltsanalyse für bestehende Kontaktdaten". What do you think about? :)

Applied :)

[MizukiTemma]

@JoeyStk
Thank you for your review 👍

1. Icon
   Planned are preview at 👁️ and a link to the page/event/location edit form at ✏️. The later is added now. As our preview functionality is currently only avaialble for pages, it is not yet implemente in this PR. If this idea gets confirmed, the preview function must be first extended for event and page, then added to the icon.

[MizukiTemma]

@JoeyStk
2. User navigation
Alternatively to the icon ✏️ next to the content title, we can add here a button "Go to page/event/location" which brings users to the edit form of the content.
And/or another button to create a new contact per ajax? (for this we will need first #3196 )

3. Search per keyword
   I considered the same first and found some difficulty/complexity:

• Words that can be a keyword are probably used in a totally different context too. For example, "Kontakt" in "Kontakt mit Krankheitserregern". It can result in too much false positiv.
• Keywords are not limited. "Ansprechpartner" sounds very good as keyword, but contact person may be mentioned as "Berater:in" or "XYZ is zuständig" or "Hier können Sie sich wenden" too. We cannot search for every expression.
• Keywords are translated in other languages. We could search for "Ansprechpartner", but how is this single word translated in other languages? if we only search for "Ansprechpartner" in german translations, we miss such case that different contact informations are given depend on the language.

If we ignore edge cases and go without precision, the search can be extended.

4. Automatic contact generation
   I dreamed of this 😓
   Automatic creation is not possible, as every contact requires a POI.

if on click on the button the information already gets transferred to the form and would be filled out already.

Do you mean putting detected phone number and E-mail address into a contact form?

[JoeyStk]

Icon
Planned are preview at 👁️ and a link to the page/event/location edit form at ✏️. The later is added now. As our preview functionality is currently only avaialble for pages, it is not yet implemente in this PR. If this idea gets confirmed, the preview function must be first extended for event and page, then added to the icon.

Ah, thank you for clarifying

2. User navigation
   Alternatively to the icon ✏️ next to the content title, we can add here a button "Go to page/event/location" which brings users to the edit form of the content.
   And/or another button to create a new contact per ajax? (for this we will need first Add contact creation in POI form #3196 )

I think that the "button"/CTA should be to create a contact from the found information. Therefore I'd rather stick to the icon?

3. Search per keyword

Yeah, right. I also don't have an idea for this 😅

4. Do you mean putting detected phone number and E-mail address into a contact form?

Yes, my idea would be to have button like "Convert to contact" right of the phone number / e-mail address. When I click on the button I get to a contact form and the found information (so for example the found phone number/e-mail address) is already filled out, which makes it easier for me and I don't have to copy/paste anything? I'll try to prepare a commit for this, to make it clear what I mean exactly :)

Automatic contact generation
I dreamed of this 😓
Automatic creation is not possible, as every contact requires a POI.

Yes, that is not what I meant. I think it's a good thing, that the municipalities still have to go through the list of found information, but I would like to make it as easy for them as possible :)

[JoeyStk]

@MizukiTemma I've now added a commit for the minimal effort "convert to contact" functionality. If you find the time, please let me know what you think about it and feel free to drop it again, if you don't like it :)

[MizukiTemma]

@MizukiTemma I've now added a commit for the minimal effort "convert to contact" functionality. If you find the time, please let me know what you think about it and feel free to drop it again, if you don't like it :)

That looks nice 😸 I would name it rather "Create a contact from this information" or something, because the "Convert to contact" sounds as if a contact would be generated automatically and/or the link would be replaced with it.

[MizukiTemma]

@osmers This is the current state.

Users find the link "Inhaltsanalyse für bestehende Kontaktdaten" (en: Analysis of content for existing contacts)

After clicking it, the suggestion list appears.

It looks like this if there is no E-mail address or phone number detected

and this, if any suggestion exists. All entries are closed as default.

Users can open and see the detail

By clicking "Zu Kontakt konvertieren", users will be taken to the contact form and can create a new contact
(The screen shot below is the case when the link next to "hello-google @ translate.me" is clicked. The selected address or number is input automatically.

How do you find it? We can also merge this PR (it's anyway available only for us) so Searvice Team can actually test around.

note
One thing to fix is formatting of phone number in the contact form. Currently numbers will not be automatically reformatted to "+49........." in the contact form but in the contents. This causes that +49123456789 in a content will not be matched with a contact object that has 0123456789. We have to either not reformatt all over our system or reformatt always everywhere (or take both format into consideration while searching for possible matches).

[osmers]

@MizukiTemma thank you for all the screenshots and explanation - @JoeyStk took me through the function on his system as well and we tried out a few different things which really helped to get a clearer picture :)
We found a few things, e.g. email address is input into the phone number field when clicking convert, already added contacts are a bit hard to match to the shown contact details on the left (there needs to be some visual distinction), and when the contact is then inserted into the page as a contact card, it still shows up in the list. I think @JoeyStk will write a more detailed reply with examples :)
That all said - I think it's great that we are offering something to the municipalities to help them in the process - so thank you very much for what you have already done on this PR :) 💪

[JoeyStk]

Finally, here comes the list:

• When converting an e-mail-address to a contact, then it's also shown as a phone number. This happens, because in my quick commit I put everything in the phone field, as I thought that it was okay for a quick demonstration. Do you want to fix this or should I? :)
• The phone number is a CharField, this means we don't have verification the input is really an phone number. Can we add something to make sure of this? -> Valify phone number input in contact form #3381
• It is difficult to see understand which contact information belongs to which contact (there needs to be some visual distinction)
• Once a contact is inserting, the according phone number and e-mail shouldn't be shown in the list anymore
• Could we convert the list to a table? Hopefully with this it's clearer what belongs together and what not :)
• Because we use the collapsible box template it expects an icon and because we haven't added one, now there is quite a bit of blank space next to the headline
• "Convert to contact" should disappear when an contact to this information already exists

[MizukiTemma]

@JoeyStk / @osmers

"Convert to contact" should disappear when an contact to this information already exists

We don't know if any of matched contacts is a good replacement of the target E-mail address/phone number. Users maybe want to create a new contact. I'm for leaving "Convert to contact" always.

Once a contact is inserting, the according phone number and e-mail shouldn't be shown in the list anymore

Ah, I see, the phone number and/or E-mail addresss and/or POI of an embedded contact card are detected as link and listed (both in the contact suggestion and the broken link list). Related to #3280?

[MizukiTemma]

It is difficult to see understand which contact information belongs to which contact (there needs to be some visual distinction)

What about showing matched contacts as card? (that was once suggested in the discussion, if I remember correctly)

[osmers]

We don't know if any of matched contacts is a good replacement of the target E-mail address/phone number. Users maybe want to create a new contact. I'm for leaving "Convert to contact" always.

I'm not so sure - I see your point about the system not knowing if the contact is a good match/replacement, but on the other hand, users don't see any progress that way....

[osmers]

It is difficult to see understand which contact information belongs to which contact (there needs to be some visual distinction)

What about showing matched contacts as card? (that was once suggested in the discussion, if I remember correctly)

Better - however I still need to check which contact card belongs to which contact detail - could we maybe style it, so that it works as a table with columns? That would mean that in this example the phone number, which belongs to the second contact card, would show up further down so that it is in line with the beginning of the contact card it belongs to. What do you think? And if there is more than one contact detail that belongs to the card, they should be placed directly below each other (in the same row as the card). If they are found in more than one card, they should also show up more than one, imho.

[MizukiTemma]

It is difficult to see understand which contact information belongs to which contact (there needs to be some visual distinction)

What about showing matched contacts as card? (that was once suggested in the discussion, if I remember correctly)

Better - however I still need to check which contact card belongs to which contact detail - could we maybe style it, so that it works as a table with columns? That would mean that in this example the phone number, which belongs to the second contact card, would show up further down so that it is in line with the beginning of the contact card it belongs to. What do you think? And if there is more than one contact detail that belongs to the card, they should be placed directly below each other (in the same row as the card). If they are found in more than one card, they should also show up more than one, imho.

Do you mean: there is a phone number N and an E-mail address E in a page. There are three contacts (1, 2, 3) which has both N and E, another three (4, 5, 6) only with N and other three (7, 8, 9) only with E. In this case:

contact detail	matched contacts
N	Card 1
	Card 2
	Card 3
	Card 4
	Card 5
	Card 6
E	Card 1
	Card 2
	Card 3
	Card 7
	Card 8
	Card 9

I'm afraid of too much duplicate (in the above example cards 1, 2, 3 are shown twice). The more contact details found in a page, the more duplicate can be caused. We may think then we can shouw contact cards that contains both N and E only once on the top of the list, but the number of possible combinations of one number and one E-mail increases rapidly if there are more than two.

[MizukiTemma]

@JoeyStk @osmers

The phone number is a CharField, this means we don't have verification the input is really an phone number. Can we add something to make sure of this?

A new issue is opened, as it's outside of scope of this issue #3381